jQuery Grid Plugin - jqGrid

I think the "losing selection" problem happens whenever a new page is fetched.

There's also an issue with wide grids (with a horizontal scrollbar) where every time a new page is fetched, it scrolls back over to the left.

I'll see if I can fix these over the w/e.

Mark

MarkC: Can you post a link to your example? It'll make it easier to reproduce the error.

Im about to start working on various scroll issues, including losing selection, so should have fixes later today.

Mark

The issue with -ve row numbers, and other oddities is because you're returning invalid data.

When you get down to one record, your returned data is:

Which is wrong - page, and total should be 1.

If you filter slightly less, and get 2 rows, then page, and total are correctly reported as 1.

I havent checked, but Im pretty sure this is also the cause of the IE7 errors.

I'm mostly done with the fixes for the other issues - I'll be pusing to my fork of the grid later today.

Mark

I think so. Or, if you're concerned about efficiency, just check for non-null rather than calling isFunction. That seems to be the standard way of dealing with optional callbacks throughout jQuery…

Well, I realized as I did it that I was writing more code that depended on this… but there's no real way around it until the problem of “p” and “grid” being shared is addressed.

One very simple way to fix the problem would be to rename the “p” parameter(say as pin), and then move the “var p = $.extend(…,pin)” and “var grid ={…}” inside of the “return this.each” loop. With that, I think everything continues to work with no need to rewrite any of the methods, except that now $(”#grid1,#grid2″).jqGrid(opts) does the right thing.

Fixing it that way does result in multiple copies of the grid (as in table.grid) object's functions (although, nobody can be using the grid this way right now, because it wouldnt work – and we already have one copy per grid on the page). But with a little effort we could change the grid object into a class, and have a single copy of all its methods shared by all the grids on a page.

I would be happy to make these changes. I dont think its a big deal – I've not seen anybody complain that $(”#grid1,#grid2″).jqGrid(opts) doesnt work! Its just that the code is written so that it would create two grids in that situation, but neither of them would work…

Mark

tony said:

Mark,

Just pushed the changes for the callbacks. I do not have tested it fully.

Hi Tony,

There is one issue... in populate, I added a variable lc which is supposed to be either a copy of loadComplete, or a function that calls loadComplete and then fetches the next page (in scroll mode, you may need to fetch more than one page at a time).

Your rewrite breaks that, and the subsequent pages wont be fetched.

Otherwise, I see you've switched to using call for most of them, which gives them a context. I think its good to define the context they're called in - but for a few, its actually a change of context. For example:

Mark C said:

Mark, did you solve the mulit-selecting problem? I uploaded the new grid.base.js file from GIT, into

I actually wasnt able to reproduce it, and assumed it was related to the loss of selection problem, which is fixed.

I just took a look at your example, and the problem is that you're not providing row-id's, so the grid is auto-generating them, and /that/ isnt working very well in scroll mode (its generating ids 1-20 over and over). I should be able to fix that - although you will probably want/need to provide ids for any serious work.

Mark