Forum
Log In
Home
Topic RSS
12:36
30/07/2009
Offline
This is a both a feature request, and a proposed implementation.
I'd like the user to be able to re-order columns in the grid. I've put an implementation in my fork of the jqGrid project on github.
The implementation provides a “reorderColumns” method, which allows you to supply a column permutation, and a flag to specify whether or not to re-order the cells in the table body (it may be that you need to request fresh data from the server, in which case its a waste of time to reorder the cells).
In addition, there's a new grid option: “sortable”. If this is “true-ish”, the grid header row will be made sortable using jquery-ui's sortable utility. If “sortable” is a function, then it gets called when the user re-orders the columns.
The change is here: http://github.com/markw65/jqGr.....4cded58ef0
Tony: I hope you will consider taking this – or at least using it as the basis of support for this feature.
Mark
00:06
30/07/2009
Offline
In case anyone's looking at this and having problems with the repository - I managed to get my fork (markw65/jqGrid) completely messed up.
After fighting git revert/reset and other magic incantations, I eventually gave up, deleted the entire fork, and recreated the changes.
The commit is now http://github.com/markw65/jqGr.....c835efb23c
Mark
10:10
Moderators
30/10/2007
Offline
Hello Mark,
Thank you very much for this pice of code.
Will replay more detailed tomorrow.
Best Regards
Tony
For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.
13:40
30/07/2009
Offline
Hi Tony,
You're welcome. A couple of comments...
It works well in my grids, but there are a number of things I dont use. Potential issues include the filter toolbar (probably easy to add support), and tree-grids/sub-grids (not sure how it will work there!).
Also, its not very configurable... I've made some local changes so the "sortable" option can be a property map (rather than just "true", or a "callback") to let the user override the sortable behavior. I'll probably check those in later today.
Mark
13:03
Moderators
30/10/2007
Offline
Hello Mark,
Just finished a test for the new feature of column reordering. Work good and the code is minimal. Here are my notes.
1. There is no check for the subgrid column - we can add a class to this so it is not a problem
2. There is no check for the treeGrid expanded coulmn. I think that this can be solved easy too.
3. The implementation can work only when repeatitems is set to false in the xml or json reader - Serious problem. To be a honest I have a some code for reordering columns, but the only problem was this. It can be solved, but it will impact the speed which I do not want.
4. The more important problem (bug) for me is: try first to click on colums and then hold the mouse and reorder the column - the result is : the grid first sort and then moves the column - in result of this the data (in table body) is not reordered.
Not sure how this can be solved, since I have not look deep into the code.
In short here is my plan.
In Saturday or Sunday I will publish another bug fix release and after this I will begin to work on 3.6 release.
The release will include
1. The jQuery UI calling convention. It seems that your code work ok.
2. Column reordering with the limitation that it will work only when repeatitems is set to false. Later we will find a better solution.
3. Making all ajax calls configurable from the developers (xml or json post or custom function)
4. rtl support.
5. User defined validators in editing modules and other minor additions.
Any help on these will be welcome.
I hope you will find the last bug (point 4) If this problem is solved I think we can add this feature.
Best Regards
Tony
For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.
13:57
30/07/2009
Offline
Hi Tony,
1 & 2 - yes. I've not used those modes. As you say, its probably not hard to deal with, but needs test tables to try it out on.
3 - actually, I have repeatitems set to true in my grid. But I can request the columns in any order from the server. The main reason for the "update" callback, is to update the postData to reflect the new column order.
4 - just fixed in my fork
Mark
14:05
Moderators
30/10/2007
Offline
Hello Mark,
Will check this tomorrow (my time). Thanks.
Best Regsrds
Tony
For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.
23:06
30/07/2009
Offline
On 2), as I said, I hadnt given it much thought, because I already specify the column order in each request to the server anyway. But how about allowing repeatitems to be an array, and if so, use that to permute the column order in the json/xml readers?
Then reorderColumns could update the array (if it is one), or leave it to the user to arrange for the server to modify the column order if its true.
As a simplification for the user, it could treat an empty array the same as "true", except that reorderColumns would update it to the new permutation... so:
If you want to have the grid take care of reordering, you use [] as the initial value for repeatitems, and if you want to take care of the reordering on the server side you use true as the initial value.
Im afraid Im going away for the weekend, so wont be able to do any work on this before monday - but it looks like it should solve the issue quite nicely (and without too much code).
Also - I like the 3.6 plan 🙂
I'll be happy to help as time (and my understanding of the code) allows.
Mark
17:23
30/07/2009
Offline
Tony: on 4) I've just posted a cleaner fix.
Mark
07:54
Moderators
30/10/2007
Offline
Hello Mark,
Thanks.
Today I just play detailed with this. Found some other bugs, but let me do other additional tests. Will replay soon.
Best Regards
Tony
For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.
08:50
30/07/2009
Offline
Ok. Let me know what you find, and if I can help.
By the way, my "cleaner fix" for 4 didnt make it to gitHub - I'll make sure to push it when I get home from work.
Mark
11:08
Moderators
30/10/2007
Offline
Hello Mark.
Here are the bugs:
1. There was not checking if a tillterToolbar is activated - second tr in the header.
I fix this when I change the resortRows function.
something like
function resortRows(parent, clobj) {
if (!clobj) clobj ="";
$("tr"+clobj, parent).each(function() {
var row = this;
var elems = $.makeArray(row.cells);
$.each(permutation, function() {
var e = elems[this];
if (e) {
row.appendChild(e);
}
});
});
}
and then
new line
if($(".ui-search-toolbar",ts.grid.hDiv))
resortRows($("thead:first", ts.grid.hDiv),".ui-search-toolbar");
2. There was not checking when a footer is present
I just add in remapColumns this lines
if(ts.p.footerrow)
resortRows($("table", ts.grid.sDiv));
Not sure, but I think that additional code should be done for grid.footers object
3. The checking here
"items": 'th:not(:has(.cbox,.jqgrid-rownum),:hidden)',
is bad - the classes are in the body and not in the header.
(I think we should use the ids which are created (rn, subgrid and cb) for thes coulmns)
The most important problem is if I explicity disable some column that I do not want to be sortable - instead the yellow marker apper and can be moved it.
All of these just are recommendatins and of course can be done better IMHO.
I'm just let you known.
I will continue on this. Just think how to implement easy when repeatitems is true.
Best Regards
Tony
For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.
16:08
30/07/2009
Offline
Hi Tony,
1) I think your fix is only needed when keepHeader is true. So perhaps better to keep you change to resortrows, and then change
if (!keepHeader) {
resortRows($("thead:first", ts.grid.hDiv));
}
to
resorRows($("thead:first", ts.grid.hDiv), keepHeader ? ":not(:first)" : "")
2) Yes, I think something like: grid.footers = $(".ui-jqgrid-ftable",grid.sDiv)[0].rows[0].cells;
3) You're right - cbox is fine (its both on the header and in the body), but jqgrid-rownum is not. So it should presumably be #jqgh_rn.
I was reluctant to use those ids, since they are duplicated bewteen grids - and you had agreed (in another thread) to fix them...
But 16I've just tried 'th:not(:has(#jqgh_cb,#jqgh_rn),:hidden)', and it seems to work.
I dont quite follow "The most important problem is if I explicity disable some column that I do not want to be sortable – instead the yellow marker apper and can be moved it"...seems to me that anything not in items cant be moved.
I'll update my fork, and see if I can fix the repeatitmes issue tonight.
Mark
00:34
30/07/2009
Offline
I've pushed various fixes to gitHub. Should now work with subgrids, footers, fitlerToolbar and rownumbers (also with rows containing tables).
I've not tried treegrid - but I dont expect it to be an issue (if it is, let me know and I'll create a test case).
I've not had time to fix the repeatitems issue - maybe tomorrow.
Mark
03:21
Moderators
30/10/2007
Offline
Hello Mark,
Thanks. Everthing work now better.
Two additional fixes:
the fiirst one - we will be sure that we apply the reordering to jqGrid rows
if (updateCells) {
resortRows($("tbody:first", ts.grid.bDiv),".jqgrow");
if (ts.p.footerrow) {
resortRows($("tbody:first", ts.grid.sDiv));
}
}
The second one will fix the treeGrid and the last sorting column
ts.p.lastsort = $.inArray(ts.p.lastsort, permutation);// checking needed
if(ts.p.treeGrid) ts.p.expColInd = $.inArray(ts.p.expColInd, permutation); // checking needed
The last can be done more elegant, but for now it works ok.
What I want is: I want make some kind of optimzation:
Now we call resortArray 3 times and with the last fix it is 5 times- so we make 5 diffrent loops on same array (permutation).
I think this can be done at once.
Best Regards
Tony
For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.
03:45
Moderators
30/10/2007
Offline
Hello again,
A couple of errors in IE 8. Will check these.
Regards
Tony
Please ignore this post. All is ok. Forgot to copy all the JS files.
Sorry
For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.
08:59
30/07/2009
Offline
So, if we add ".jqgrow" to the condition for the main table, I can drop ":not(.ui-subgrid)" from resortRows right?
lastsort/treegrid - good catch 🙂
Not sure what the point of the "optimization" is? I think we /could/ fix it so that all rows were passed into resortRows using a single select expression - but note that the $.each(permutation...) loop is called for each row anyway.
Besides - the time for the browser to reorder and redraw the table cells will far exceed the loop overhead. And remapColumns is a ui thing anyway - its not something you're going to call hundreds of times in a tight loop...
... unless Im missing something? Is there something specific you're trying to fix?
If there /is/ a need to speed it up, both resortRows, and resortArray could be fixed to only operate on the changed columns - and in particular could be optimized for the case where only one column is moved (which is always the case when called from .sortable).
Mark
09:17
Moderators
30/10/2007
Offline
Yes,
Just discover, after reorder, I need to click two times to sort the column, not sure but it is connected with the new variable
disableClick
For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.
09:21
Moderators
30/10/2007
Offline
About optimization
I speak about resortArray function and this
resortArray(ts.p.colModel);
resortArray(ts.p.colNames);
resortArray(ts.grid.headers);
ts.p.lastsort = $.inArray(ts.p.lastsort, permutation);
if(ts.p.treeGrid) ts.p.expColInd = $.inArray(ts.p.expColInd, permutation);
We call 5 times each on permutation array
For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.
10:56
30/07/2009
Offline
I've pushed the latest fixes.
This includes code to handle repeatitems true. Tested with jsonReader - I /think/ the xml code should work too, but dont have an xml datasource configured. Let me know.
disableClick: not sure what's going on. If I take it out, the columns always sort after shuffling; if I leave it in, it does seem to disable the first click after shuffling. I think its better with it than without, but I'll try and figure out exactly what's causing it...
The optimization. Note that the $.each(permutation...) gets called once for each /row/ (in resortRows), in addition to once per call to resortArray - I really dont think the overhead is significant (compared to the cost of doing resortRows). But yes, I could make a single loop over permutation to handle those 5 operations.
Mark
Most Users Ever Online: 715
Currently Online:
65 Guest(s)
Top Posters:
OlegK: 1255
markw65: 179
kobruleht: 144
phicarre: 132
YamilBracho: 124
Renso: 118
Member Stats:
Guest Posters: 447
Members: 11373
Moderators: 2
Admins: 1
Forum Stats:
Groups: 1
Forums: 8
Topics: 10592
Posts: 31289
Newest Members:
, razia, Prankie, psky, praveen neelam, greg.valainis@pa-tech.comModerators: tony: 7721, Rumen[Trirand]: 81
Administrators: admin: 66
