jQuery Grid Plugin - jqGrid

Hi Tony,

I found some bugs in form editing and analased the problem exactly. The problem is common and there are many ways to fix it. I'm not sure which way you prefer so I desided first to write the bug report before posting one of the fix.

At the beginning I found that onclickSubmit will be called sometimes with wrong value of frmoper parameter. Then I found that the problem that place if the default recreateForm:false are used, the user first opens Add dialog and then opens Edit dialog. In the case frmoper parameter will be always "add". If the user first opens Edit dialog then onclickSubmit will have frmoper parameter always as "edit". Later analyse shows that beforeCheckValues, beforeSubmit and many other callbacks will be allways called with all options of the first opened dialog (either Add or Edit).

Now I found the reason of the problem very quickly. editGridRow method create the form only once. After that it uses bind("click") and keydown (see the line, the line, the line, the line, the line and so on) to register event handlers. At the moment the new execution context with the corresponding outer variables will be created. So everytime when click-event handler will be executed it sees the options (one from outer variables) of the first opened dialog (Add or Edit).

The click event handles calls postIt, checkUpdates, fillData, getFormData. postIt function for example uses $t, IDs, frmgr, frmoper, frmtb, gID, p, postdata outer variables. LSLint displays the list of all outer varaibles used in all functions (all outer variables of all closures). It can be used to find all references to outer variables. So the values of the variables could be wrong.

One can demonstares the problem on the following simple code

There are many ways to fix the problem:

• uses allways only recreateForm:true. In other words remove some part of editGridRow code and remove previous form directly on the start of editGridRow or just destroy the form instead of making it hidden. Some advantage of the approach – one solve the problem with multiple grids on the same page which have the same names of columns.
• unbind and rebind all event handler always. the form can still stay hidden on close.
• save all options with respect of jQuery.data in DOM element of the form. The event handlers should don't use any outer variables dierctly. Instead of that one should use jQuery.data to get the options and then do the rest.

The first code demonstrates the solution with unbinding/rebinding:

The next code fragment demonstrates the usage of jQuery.data:

The jsfidle demo demonstrates the both  code which I included.

You should decide Tony which way you choose and fix the code coresponds to the choice.

Best regards
Oleg