jQuery Grid Plugin - jqGridForum

Topic RSS

sortArrayData - will not reverse sorting?

14/02/2010
15:40

Les

Member

Members

Forum Posts: 44

Member Since:
11/12/2009

Offline

I believe there's an inefficiency in the sortArrayData() function. This method is not reversing results of an already sorted array, but it instead it sorts it again.

Reversing an already sorted array is much faster, so the rows.reverse() method should be used when rows are sorted and we want to reverse the order.

15/02/2010
15:50

Les

Member

Members

Forum Posts: 44

Member Since:
11/12/2009

Offline

I wanted to add more detail. When I click consecutively on the column header to sort grid data, the code below inside sortData() is called.

rows.sort(function(a, b) {

if (a.sortKey < b.sortKey) {return -newDir;}

if (a.sortKey > b.sortKey) {return newDir;}

return 0;

});

This code is not efficient because it sorts an already sorted array. When the array is sorted and we want to sort it (on the client) in reverse order (by clicking on the same column header), the rows.reverse() method should be used.

rows.reverse()

15/02/2010
16:04

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello,

Already done in GitHub

http://github.com/tonytomov/jq.....dcd50b0c9c

Thanks.

Best Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
69 Guest(s)

Currently Browsing this Page:
1 Guest(s)