jQuery Grid Plugin - jqGridForum

Topic RSS

Related Topics sp_TopicIcon

removing special characters from ids

Tags: id

06/04/2011
20:16

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Hello Tony,

One common problem of newcomers is the usage of special characters like spaces (blanks) in the places which will be used as ids or to construct ids: the name property of colNames or ids of the rows. The name property will be used for example to build ids of the <th> elements of the table (see line 2039 of grid.base.js).

I suggest:

1) to include a the and of for loop at the line 1955 some additional lines:

for (i=0; i<ts.p.colModel.length;i++) {
   ts.p.colModel[i] = $.extend(true, {}, ts.p.cmTemplate, ts.p.colModel[i].template || {}, ts.p.colModel[i]);
   if (ts.p.keyIndex === false && ts.p.colModel[i].key===true) {
   ts.p.keyIndex = i;
   }
   if(typeof(ts.p.colModel[i].index)) === "undefined") {
   typeof(ts.p.colModel[i].index = ts.p.colModel[i].name;
   }
   ts.p.colModel[i].name = $.jgrid.jqID(ts.p.colModel[i].name);
}

The code will allows to use special charactres (like 'id asc, name asc') in the index, but not in the names.

2) Expand the code of jqID to remove all characters which not corresponds to the W3C CSS specification at least space characters as the most common problem.

Best regards
Oleg

07/04/2011
11:37

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello Oleg,

I'm not sure that this fix is the appropriate.

Imagrine the field contain . (dot) after this fix and after query the name we will have escaped name - i.e not correct.

Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

07/04/2011
12:35

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

You are right Tony,

one can not use the line

ts.p.colModel[i].name = $.jgrid.jqID(ts.p.colModel[i].name);

Probably one should only replace ts.p.colModel[i].name to $.jgrid.jqID(ts.p.colModel[i].name) in the lines 2039 and 2041 of grid.base.js.

The removing of characters, which are not permitted in id (like blanks), from the string which returns $.jgrid.jqID() seems me desirable regardless of all other things.

Best regrads
Oleg

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
52 Guest(s)

Currently Browsing this Page:
1 Guest(s)