jQuery Grid Plugin - jqGridForum

Topic RSS

multiple select problem when row id has whitespace

18/09/2009
07:06

adige

New Member

Members

Forum Posts: 1

Member Since:
18/09/2009

Offline

Hi,

If row id has whitespace than grid select doesn't work properly. When select changes the old selected row still looks selected (multiple select).

in grid.base.js (jqGrid 5.3.3) line 64 i added bold part, now it works fine even if id has whitespace:

return sid.replace(/:/g,"\\\\:").replace(/\\./g,"\\\\.").replace(/\\[/g,"\\\\[").replace(/\\]/g,"\\\\]").replace(/ /g,"\\\\ ");

18/09/2009
08:57

markw65

Member

Members

Forum Posts: 179

Member Since:
30/07/2009

Offline

According to the jquery page, here is the complete list of chars that need quoting: #;&,.+*~':"!^$[]()=>|/

So clearly there's a few more that need adding 🙂

Also, rather than adding a series of replace calls, it could be written: sid.replace(/([\\#\\;\\&\\,\\.\\+\\*\\~\\'\\:\\"\\!\\^\\$\\[\\]\$\$\\=\\>\\|\\/])/g,"\\\\$1");

Or maybe just quote everything but the "usual selector chars": sid.replace(/([^-a-zA-Z_0-9])/g, "\\\\$1");

18/09/2009
10:48

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Thanks adige,

Thanks Mark, as usuall good catch, but I think that we should follow some standarts about what are allowed characters for the id

http://www.w3.org/TR/REC-xml/#NT-Name

It seems that XHTL is a subset of HTML specs,

So I think we should apply this for the following chars (finally): [,],-,_,:,.

I will apply your fix where is no need to make a series of replace calls.

This should remember me that I must correct the id's in the grid where we should not have duplicate id.

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
63 Guest(s)

Currently Browsing this Page:
1 Guest(s)