jQuery Grid Plugin - jqGridForum

Topic RSS

Related Topics sp_TopicIcon

grouping of XML/JSON data with repeatitems:false in the reader

Tags: grouping

12/09/2010
16:00

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Hi Tony!

It seems that current code from grid.base.js allow grouping of XML data only if repeatitems:false. See http://www.ok-soft-gmbh.com/jq.....Log38_.htm as a demo. If I change the lines 1109 and 1110:

if(ts.p.grouping && F) {

$(ts).jqGrid('groupingRender',grpdata,F.length+gi+si+ni);

if(ts.p.grouping) {

$(ts).jqGrid('groupingRender',grpdata,(F? F.length: ts.p.colModel.length)+gi+si+ni);

It works: see http://www.ok-soft-gmbh.com/jq.....38_new.htm. I don't test the changes in case of having some hidden columns or some other non standard situations.

It seems that the same problem exist for JSON data (see lines 1272-1273).

Best regards
Oleg

12/09/2010
17:15

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Oleg,

Thanks again. The real fix is:

if(ts.p.grouping) {

$(ts).jqGrid('groupingRender',grpdata,ts.p.colModel.length);

...

Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

12/09/2010
17:46

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Very good!

Your last version looks really clear. I didn't read full code before with gi,si and ni are calculated. So I was too cautious Smile .

Thanks. I could already see the new code on github.com.

Regards
Oleg

21/09/2010
21:23

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Hi Tony!

After downloading releasede version of jqGrid 3.8 I had the same problem which i described before. After debugging I could see that the jqGrid 3.8 not what you write befor or what I suggested. It has a combination of one old line and one new line:

if(ts.p.grouping && F) {

$(ts).jqGrid('groupingRender',grpdata,ts.p.colModel.length);

One should remofe '&& F' from the 'if' (line 1272) to fix the problem.

Best regards
Oleg

21/09/2010
23:41

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Oleg,

Thanks again. Not sure why this happen, because I'm sure I have corrected this in a way that I have write it in my previous post

Instead the problem is Fixed. We will maybe realease 3.8.1 soon.

Thank you.

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

22/09/2010
00:07

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Hello Tony,

you are right in http://github.com/tonytomov/jq.....3 one can see that you changed the code exactly like you wrote in the thread before. At the end it's not important how some error come. More important to find the more errors as possible and fix there.

A release of 3.8.1 soon after collecting some feedbacks is a good idea.

Best regards
Oleg

P.S. In the next weeks I will be not so active on the forum because of I should bring one project to the final end to have money for me and my family. Laugh

24/09/2010
09:25

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Oleg,

The last comment in your last post is the most important think Smile

Kind Regards

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
33 Guest(s)

Currently Browsing this Page:
1 Guest(s)