jQuery Grid Plugin - jqGridForum

Topic RSS

formedit default text field length - grid.common.js

13/04/2009
21:59

akremedy

California, USA

Member

Members

Forum Posts: 37

Member Since:
16/12/2008

Offline

Hi Tony, I think there's a little defect in grid.common.js. If you don't include the colModel parameter "editoptions:{size:#}", text fields should default to 98%, password to 99%.

In grid.common.js, in createEl, in case "textarea", case "text" and case "password", it looks for:

if(!options.size && elm) {

It appears that this should be:

if(!options.size && elem) {

I tested this change, and it seems honor the % width only with the modified variable in place.

This happens to be the 3.5A2 release, but it looks like it may go back to at least 3.3.2.

Thanks,

Adam

14/04/2009
01:03

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello,

Thanks - IMHO the condition should be changed to:

if(!options.size) {

for password, and text

and

options.cols is for textarea.

the parameter elm in createEl is not needed.

The % should be equall to all. Thanks

Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

14/04/2009
03:42

akremedy

California, USA

Member

Members

Forum Posts: 37

Member Since:
16/12/2008

Offline

Thanks Tony, that actually makes even more sense - and simpler too.

Adam

14/04/2009
11:02

Keith Ivey

Washington, DC, USA

Member

Members

Forum Posts: 9

Member Since:
07/04/2009

Offline

That's fine for text, password, and textarea because you can avoid it by setting size or cols. But for select there needs to be a way to avoid setting the width to 98% or 99% or whatever is decided. I'd prefer not having that happen at all, just leave them at the width the browser gives them (based on the width of the options), and let people set it to 99% in the stylesheet if that's what they want.

16/04/2009
02:08

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello Keith,

Done in 3.5 alfa 3 (the width of the select)

Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

16/04/2009
12:21

akremedy

California, USA

Member

Members

Forum Posts: 37

Member Since:
16/12/2008

Offline

Cool, thanks Tony!

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
55 Guest(s)

Currently Browsing this Page:
1 Guest(s)