jQuery Grid Plugin - jqGridForum

Topic RSS

Related Topics sp_TopicIcon

Fixing calls of hideModal and setting this in onClose

Tags: hideModal this

11/11/2012
16:25

OlegK

Germany

Member

Members

Forum Posts: 1255

Member Since:
10/08/2009

Offline

Hello Tony,

first of all one should fix three places of calling $.jgrid.hideModal with wrong first parameter. The line of the code of createModal

self.hideModal(this,{gb:p.gbox,jqm:p.jqModal,onClose: cone});

should be fixed to

self.hideModal("#"+$.jgrid.jqID(aIDs.themodal),{gb:p.gbox,jqm:p.jqModal,onClose: cone});

In the same way another line of the code of editGridRow

if(cle) {$.jgrid.hideModal(this,{gb:p.gbox,jqm:p.jqModal, onClose: rp_ge[$t.p.id].onClose});}

should be fixed to

if(cle) {$.jgrid.hideModal("#"+$.jgrid.jqID(IDs.themodal),{gb:p.gbox,jqm:p.jqModal, onClose: rp_ge[$t.p.id].onClose});}

and the line of viewGridRow

if(rp_ge[$t.p.id].closeOnEscape) {$.jgrid.hideModal(this,{gb:p.gbox,jqm:p.jqModal, onClose: p.onClose});}

should be fixed to

if(rp_ge[$t.p.id].closeOnEscape) {$.jgrid.hideModal("#"+$.jgrid.jqID(IDs.themodal),{gb:p.gbox,jqm:p.jqModal, onClose: p.onClose});}

Additionally I suggest to adjust a little the code of hideModal to call onClose method with the value of this exactly the same as for all other callbacks of jqGrid inclusive callbacks of form editing. To do this one can change the line of code of hideModal

var oncret = o.onClose(selector);

var oncret = o.gb && typeof o.gb === "string" && o.gb.substr(0,6) === "#gbox_" ?
o.onClose.call($("#" + o.gb.substr(6))[0], selector) :
o.onClose(selector);

Best regards
Oleg

12/11/2012
09:42

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Thanks Oleg.

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
37 Guest(s)

Currently Browsing this Page:
1 Guest(s)