jQuery Grid Plugin - jqGridForum

Topic RSS

DataUrl: ajax should use "success", not "complete"

15/06/2010
02:24

vchekan

Member

Members

Forum Posts: 10

Member Since:
07/06/2010

Offline

http://github.com/tonytomov/jq.....on.js#L321

if(typeof(options.dataUrl) != "undefined") {

...

complete: function(data,status){

  if(typeof(options.buildSelect) != "undefined") {
    var b = options.buildSelect(data);

I have strong impression that "complete" property was used by mistake.

First, of all, you perhaps do not want to feed error-ended call into buildSelect()

Second, "data" is XMLHttpRequest in fact. If you change "complete" to "success", then 1st argument will be "data" as intended.

16/06/2010
13:08

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello,

Maybe you are right, but changing right now complete with succes will cause all existing users to change a lot of code and expect a lot of problems.

Best Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

17/06/2010
20:26

vchekan

Member

Members

Forum Posts: 10

Member Since:
07/06/2010

Offline

Well, I don't know. My guess is that most of existing code is broken, because I doubt people check that completion status is 'success'.

So may be it is possible to add a backward compatibility bit and retire old behaviour in a grace fashion?

Another option would be to introdcue another callback, let's say "dataUrlReady" which would be called properly. With clear documentation it would allow new code to do right things without breaking backward compatibility.

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
32 Guest(s)

Currently Browsing this Page:
1 Guest(s)