jQuery Grid Plugin - jqGridForum

Topic RSS

Related Topics sp_TopicIcon

custom_element and custom_value bug with boolean values

Tags: custom_element custom_value boolean false

15/06/2011
12:01

keithd

New Member

Members

Forum Posts: 1

Member Since:
15/06/2011

Offline

Hi. I'm making use of the custom_element and custom_value facility within the editoptions to create a radio button column. Data values are true, false and null and I expected the custom_element and custom_value functions to be able to convert these values into useful html content and back again.

This works as expected for the 'Yes' option but not for the 'No' option. A little digging about and I discovered this in the saveCell function:

// The common approach is if nothing changed do not do anything
if (v2 != $t.p.savedRow[fr].v)

v2 (false) and $t.p.savedRow[fr].v (empty string) aren't equal but the != coerces the values. The != should be replaced with !== which won't coerce the value types.

A similar bug is also present in the $.unformat function: when using a custom function, the value is stored in a variable called ret

ret = unformatFunc($(cellval).text(), options, cellval);

the return statement then checks the value of ret and if it is false (which should be a perfectly valid return value), substitutes it with the cells html contents.

return ret ? ret : cnt===true ? $(cellval).text() : $.jgrid.htmlDecode($(cellval).html());

Any plans to address these issues?

15/06/2011
12:10

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello,

Thanks will be fixed today and some other minor bugs too.

We plan to publish 4.1.1 at end of this week.

Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

All RSS

Forum Timezone: Europe/Sofia

Most Users Ever Online: 715

Currently Online:
45 Guest(s)

Currently Browsing this Page:
1 Guest(s)