jQuery Grid Plugin - jqGridForum

Topic RSS

checkOnUpdate not working correctly

22/10/2010
03:39

nickelj

Member

Members

Forum Posts: 28

Member Since:
15/10/2010

Offline

Hi,

I don't think the checkOnUpdate:true is working properly for a edit form.

I am referring specifically to the "No" and "Cancel" options - their functions are reversed.

The popup shows up when data is changed and a exit event is fired - good.

The popup says, "Data has been changed! Save changes?" and 3 options are shown - Yes, No and Cancel

Yes works correctly and saves the data.

However, I would expect Cancel to take me back to the modal form to let me continue editing but it exits the modal form completely (which is what I would expect the "No" selection to do.)

I would expect the No option to exit the modal form and take me back to the grid, but it returns to the modal form and lets me continue editing (which is what I would expect the "Cancel" selection to do.)

I should mention that I have closeAfterEdit:true as a property as well.

I can probably temporarily fix this by just changing the language file (or maybe that is the permanent fix) - except the positions of the buttons will be wrong then - I like the current positions.

One other issue:

The highlights (the mouseover) for the Yes, No, Cancel seem to remember their last selection.

If I change some data in a form, click the Cancel button, I get the popup - now I select "No". Then I again click Cancel, and again get the popup - now the "No" button is already highlighted and if I click the Cancel without moving over the "No", I now have both highlighted. Then if I go back in and edit a record again, and again click Cancel in order to get the popup a third time, I get "Cancel" and "No" highlighted and if I select "Yes" without moving over the other two buttons, I can now make all 3 highlighted. I have shown the last two examples here. The dark color is highlighted - the light color is without the mouseover.

Thanks!

Jim

23/10/2010
21:44

nickelj

Member

Members

Forum Posts: 28

Member Since:
15/10/2010

Offline

Just checking...is the above expected behaviour?

27/10/2010
19:11

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello,

As for the first "problem" I think that Cancel should be replaced with Exit.

Instead - English is not may native language, so maybe you have right.

You can change these values without to change the language file.

Just after loading the lang lang filedo

$.jgrid.edit.bNo = "Cancel"

$.jgrid.edit.bExit = "Nol"

As for the second problem I can not reproduce it using your description step by step.

In which browser is this?

Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

28/10/2010
01:17

nickelj

Member

Members

Forum Posts: 28

Member Since:
15/10/2010

Offline

English is my native language. I will use your "fix". However, in all the applications I can think of (think of Microsoft Word for example), if you made changes to your Word document and then clicked the Close window icon, Word would ask you if you wanted to "Save your changes?". If you say Yes, then it would Save and then exit. If you said No, then it would exit without saving changes and if you clicked Cancel, it would "Cancel" your action (this being the Close window action) and return you to your document. I think it makes sense for your "Save changes" dialog to do the same thing.

As for the second problem, you are right - I cannot reproduce it in IE. Only in Firefox.

Jim

28/10/2010
13:27

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello,

Thanks

On my FireFox on Linux there is no problem. There is no problem with Chrome on Linux too.

Will check it on my Windows VM

Kind regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

31/10/2010
15:15

tony

Sofia, Bulgaria

Moderator

Members

Moderators

Forum Posts: 7721

Member Since:
30/10/2007

Offline

Hello,

Just checked with FF 3.6.10 omn windows XP and there seems to be not a problem.

Which version of FF is used and on which OS exactley.

Regards

Tony

For professional UI suites for Java Script and PHP visit us at our commercial products site - guriddo.net - by the very same guys that created jqGrid.

31/10/2010
18:55

nickelj

Member

Members

Forum Posts: 28

Member Since:
15/10/2010

Offline

I having been using FF 3.5.7 on Windows XP (32 bit). I will try updating to the latest FF.

Thanks,

Jim

31/10/2010
19:04

nickelj

Member

Members

Forum Posts: 28

Member Since:
15/10/2010

Offline

Just tried it with 3.6.12 of FF and it worked perfectly.

Sorry for bothering you with this.

Jim

01/07/2011
13:41

damdam76

New Member

Members

Forum Posts: 2

Member Since:
01/07/2011

Offline

Hello,

Sorry for reopening this topic but it seems there is a bug with the checkOnUpdate feature in version 4.1.1 .
It look like the modification detection works great only the first time, I mean it sees there no update correctly the first time you edit a row, and then always says something as changed even if you don't modify anything !
Everything works great when switching back to version 4.0.0

Can you confirm this strange behavior ?

damdam